add nullaway to spring jms (part 2) #15409
Conversation
...lemetry/javaagent/instrumentation/spring/jms/v6_0/JmsDestinationAccessorInstrumentation.java
Outdated
Show resolved
Hide resolved
zeitlinger
changed the title
| return null; | ||
| } | ||
| // suppress receive span creation in jms instrumentation | ||
| @SuppressWarnings("NullAway") // request is typed as Void |
There was a problem hiding this comment.
i wonder if it would make sense to add @Nullable to the parameter in suppressSpan (and all the other downstream effects of that) to avoid having to suppress this?
There was a problem hiding this comment.
I tried that - and it's not working (have to look up the details if required)
There was a problem hiding this comment.
can you check? I'm asking because the reason "request is typed as Void" doesn't really seem correct here. Rather the reason seems that the method really does accept Nullable.
There was a problem hiding this comment.
InstrumenterUtil.suppressSpan() calls spanKindExtractor.extract(request) which doesn't accept a null request. Here it works because the instrumenter uses SpanKindExtractor.alwaysConsumer() that doesn't use the request.
The comment // request is typed as Void is misleading as here request is MessageWithDestination and the response is Void.
4 participants
No description provided.